Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sysvars: add tidb_shard_row_id_bits and tidb_pre_split_regions #18649

Merged
merged 8 commits into from
Oct 15, 2024
Merged

sysvars: add tidb_shard_row_id_bits and tidb_pre_split_regions #18649

merged 8 commits into from
Oct 15, 2024

Conversation

jackysp
Copy link
Member

@jackysp jackysp commented Sep 14, 2024

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 14, 2024
@jackysp
fix ci
afcacc5 
Signed-off-by: Jack Yu <[email protected]>
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 18, 2024

@Frank945946: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hfxsd hfxsd added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed missing-translation-status This PR does not have translation status info. labels Sep 18, 2024
@hfxsd hfxsd self-assigned this Sep 18, 2024
@hfxsd hfxsd added the v8.4 This PR/issue applies to TiDB v8.4. label Sep 18, 2024
@hfxsd hfxsd mentioned this pull request Sep 18, 2024
Merged
16 tasks
@hfxsd hfxsd added type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. for-release This PR relates to a TiDB release but does not have a tracked feature. labels Sep 18, 2024
hfxsd
hfxsd reviewed Sep 18, 2024
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
hfxsd
hfxsd reviewed Sep 18, 2024
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
@hfxsd hfxsd requested a review from lilin90 September 18, 2024 13:13
hfxsd
hfxsd reviewed Sep 18, 2024
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
hfxsd
hfxsd reviewed Sep 18, 2024
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
hfxsd
hfxsd reviewed Sep 19, 2024
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
hfxsd
hfxsd reviewed Sep 19, 2024
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
system-variables.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 24, 2024
@hfxsd hfxsd changed the title sysvars: add tidb_shard_row_id_bits and tidb_pre_split_regions sysvars: add tidb_shard_row_id_bits and tidb_pre_split_regions Sep 24, 2024
lilin90
lilin90 reviewed Oct 8, 2024
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
system-variables.md Outdated Show resolved Hide resolved
lilin90
lilin90 reviewed Oct 8, 2024
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
system-variables.md Outdated Show resolved Hide resolved
lilin90
lilin90 approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 8, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 8, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-24 03:09:57.983190677 +0000 UTC m=+1535467.723614611: ☑️ agreed by hfxsd.
  • 2024-10-08 09:08:58.620551251 +0000 UTC m=+950694.040764263: ☑️ agreed by lilin90.

@hfxsd
Copy link
Collaborator

hfxsd commented Oct 15, 2024

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Oct 15, 2024
@ti-chi-bot ti-chi-bot bot merged commit 85870ec into pingcap:master Oct 15, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Frank945946 Frank945946 Frank945946 approved these changes

@hfxsd hfxsd hfxsd approved these changes

@lilin90 lilin90 lilin90 approved these changes

Assignees

@hfxsd hfxsd

Labels
approved for-release This PR relates to a TiDB release but does not have a tracked feature. lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v8.4 This PR/issue applies to TiDB v8.4.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jackysp @hfxsd @lilin90 @Frank945946